Add external_link helper

web/server.rb

@@ -85,6 +85,10 @@ class VLVSearch < Sinatra::Base
     def signed_in?
       !!session['user_id']
     end
+
+    def external_link(url, text)
+      "<a href=\"#{url}\" target=\"_blank\">#{text}</a>"
+    end
   end
 
   run! if __FILE__ == $0

web/views/partials/footer.erb

@@ -2,9 +2,15 @@
   <p>
     Made by user reddwarf. This site is a third party product and not officially
     associated with VLV. Feel free to
-    <a href="http://board.vivalavinyl.com/message/create/reddwarf/">PM me</a>
+    <%= external_link(
+      'http://board.vivalavinyl.com/message/create/reddwarf',
+      'PM me'
+    ) %>
     with any questions or suggestions. This site is open source software under
     the terms of the MIT license and the code can be found
-    <a href="https://git.simulacrum.party/simulacrumparty/vlv-search">here</a>.
+    <%= external_link(
+      'https://git.simulacrum.party/simulacrumparty/vlv-search',
+      'here'
+    ) %>.
   </p>
 </footer>

web/views/results.erb

@@ -11,9 +11,10 @@
     <% results.each do |result| %>
       <div class="results__result <%= params[:type] %>">
         <% if params[:type] == "threads" %>
-          <a href="http://board.vivalavinyl.com/thread/view/<%= result[:remote_id] %>">
-            <%= result[:title] %>
-          </a>
+          <%= external_link(
+            "http://board.vivalavinyl.com/thread/view/#{result[:remote_id]}",
+            result[:title]
+          ) %>
           <p class="result__info">
             <span>
               created by <%= result[:creator] %>
@@ -28,9 +29,12 @@
         <% elsif params[:type] == "posts" %>
           <p>
             In thread:
-            <a href="http://board.vivalavinyl.com/thread/view/<%= result[:remote_thread_id] %>">
-              <strong><%= result[:thread_title] %></strong>
-            </a>
+            <strong>
+              <%= external_link(
+                "http://board.vivalavinyl.com/thread/view/#{result[:remote_thread_id]}",
+                result[:thread_title]
+              ) %>
+            </strong>
           </p>
           <p class="result__info">
             <%= result[:creator] %> posted this at <%= result[:created_at] %>